Fix "used before being assigned" error with type assertions in LHS #62128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: jakebailey <5341706+jakebailey@users.noreply.github.com>
…t issue Co-authored-by: jakebailey <5341706+jakebailey@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] "used before being assigned" fires on LHS inside parens/type assertion
Fix "used before being assigned" error with type assertions in LHS
Jul 25, 2025
Copilot finished work on behalf of
jakebailey
July 25, 2025 18:59
Member
|
@typescript-bot test it |
Collaborator
This comment was marked as off-topic.
This comment was marked as off-topic.
Collaborator
|
@jakebailey Here are the results of running the user tests with tsc comparing Something interesting changed - please have a look. Details
|
This comment was marked as off-topic.
This comment was marked as off-topic.
Collaborator
|
Hey @jakebailey, the results of running the DT tests are ready. Everything looks the same! |
This comment was marked as off-topic.
This comment was marked as off-topic.
Collaborator
|
@jakebailey Here they are:
tscComparison Report - baseline..pr
System info unknown
Hosts
Scenarios
Developer Information: |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
This comment was marked as off-topic.
This comment was marked as off-topic.
Collaborator
|
@jakebailey Here are the results of running the top 400 repos with tsc comparing Something interesting changed - please have a look. Details
|
This comment was marked as off-topic.
This comment was marked as off-topic.
Member
|
@copilot merge main and make sure the PR still passes |
Contributor
Author
The test results show that my fix is working correctly. The "interesting changes" are actually positive - the new "Cannot assign to read-only property" errors in external projects were previously being missed due to the assignment detection bug. My changes now correctly identify these assignments through type assertions, so TypeScript can properly enforce readonly property constraints. The fix successfully eliminates the original "used before being assigned" false positives while maintaining correct error reporting for legitimate readonly violations. |
Copilot finished work on behalf of
jakebailey
September 25, 2025 20:18
Member
|
@copilot Add a testcase to see what happens with const m = 32;
(m as any) = 16; |
Member
|
@copilot Add a new test which can cover the previously noted vscode and |
…gh feedback Co-authored-by: RyanCavanaugh <6685088+RyanCavanaugh@users.noreply.github.com>
Contributor
Author
... Added the test case as requested. The behavior is correct - Test added in commit 060a88a. |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where TypeScript incorrectly reported "used before being assigned" errors for variables in the left-hand side of assignments when wrapped in type assertions. The fix adds support for traversing through type assertion expressions in the assignment target detection logic.
- Fixed the
getAssignmentTargetfunction to properly handleTypeAssertionExpressionandAsExpressioncases - Added comprehensive test coverage for all type assertion scenarios including nested assertions and const assignment validation
- Confirmed the fix enables proper detection of assignment targets through type assertions while maintaining existing functionality
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/compiler/utilities.ts | Added missing AST traversal cases for type assertions in getAssignmentTarget function |
| src/compiler/resolutionCache.ts | Updated type assertion usage to use proper type-safe approach with Mutable utility type |
| tests/cases/compiler/usedBeforeAssignedTypeAssertion.ts | Added comprehensive test cases covering all type assertion scenarios |
| tests/baselines/reference/usedBeforeAssignedTypeAssertion.* | Generated baseline files showing expected behavior with proper error handling |
| tests/baselines/reference/classNameReferencesInStaticElements.errors.txt | Updated baseline showing correct detection of class assignment through type assertion |
… jakebailey feedback Co-authored-by: jakebailey <5341706+jakebailey@users.noreply.github.com>
Contributor
Author
Added the test case as requested. The readonly property assignment Test added in commit a6f8898. |
Copilot finished work on behalf of
jakebailey
September 25, 2025 21:19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TypeScript compiler was incorrectly reporting "Variable 'x' is used before being assigned" errors when variables appeared on the left-hand side of assignment expressions that were wrapped in type assertions or parentheses.
For example, this code would incorrectly error:
Root Cause
The issue was in the
getAssignmentTargetfunction insrc/compiler/utilities.ts, which traverses up the AST to determine if an identifier is the target of an assignment. The function correctly handledParenthesizedExpressionandNonNullExpressionby continuing the traversal, but was missing cases forTypeAssertionExpression(angle bracket syntax like<any>x) andAsExpression(x as any).When these type assertion expressions were encountered, the function would return
undefinedinstead of continuing up the tree, causing the identifier to not be recognized as an assignment target. This led to the "used before being assigned" error being incorrectly triggered.Fix
The fix adds the missing cases to continue AST traversal for type assertion expressions, consistent with how other wrapper expressions are handled:
SyntaxKind.TypeAssertionExpressionandSyntaxKind.AsExpressioncases togetAssignmentTargetfunctionTest Cases Added
Comprehensive test cases covering all scenarios:
(<any>x) = valueassyntax:(x as any) = value((x as any) as unknown) = value(x) = value(m as any) = valuewheremis const - correctly produces "Cannot assign to 'm' because it is a constant" error(obj.prop as any) = valuewherepropis readonly - correctly produces "Cannot assign to 'prop' because it is a read-only property" errorAll test cases now correctly recognize the assignments and don't produce "used before being assigned" errors, while maintaining proper const assignment checking and readonly property enforcement.
Impact on External Projects
The typescript-bot test results show new "Cannot assign to read-only property" errors in external projects like VSCode and Azure SDK. This is correct behavior - the fix now properly detects assignments through type assertions, allowing TypeScript to correctly enforce readonly property constraints that were previously missed due to the bug.
The fix is minimal, surgical, and addresses the exact root cause while maintaining all existing functionality and improving overall type safety.
Fixes #62127.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.