Skip to content

Conversation

@MBaesken
Copy link
Member

@MBaesken MBaesken commented Nov 28, 2025

JDK-8372720 problem listed the test compiler/arguments/TestCodeEntryAlignment.java on macOS x64 but the issue appears on other OS running on x64 CPUs (e.g. Linux) too .


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8372730: Problem list compiler/arguments/TestCodeEntryAlignment.java on x64 (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28553/head:pull/28553
$ git checkout pull/28553

Update a local copy of the PR:
$ git checkout pull/28553
$ git pull https://git.openjdk.org/jdk.git pull/28553/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28553

View PR using the GUI difftool:
$ git pr show -t 28553

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28553.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 28, 2025

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 28, 2025

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8372730: Problem list compiler/arguments/TestCodeEntryAlignment.java on x64

Reviewed-by: lucy, goetz

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 15 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title JDK-8372730: Problem list compiler/arguments/TestCodeEntryAlignment.java on x64 8372730: Problem list compiler/arguments/TestCodeEntryAlignment.java on x64 Nov 28, 2025
@openjdk
Copy link

openjdk bot commented Nov 28, 2025

@MBaesken To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • graal
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@MBaesken
Copy link
Member Author

/label hotspot-compiler

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Nov 28, 2025
@openjdk
Copy link

openjdk bot commented Nov 28, 2025

@MBaesken
The hotspot-compiler label was successfully added.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 28, 2025
@mlbridge
Copy link

mlbridge bot commented Nov 28, 2025

Webrevs

Copy link
Contributor

@RealLucy RealLucy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 1, 2025
@GoeLin
Copy link
Member

GoeLin commented Dec 1, 2025

LGTM, too.

@MBaesken
Copy link
Member Author

MBaesken commented Dec 1, 2025

Thanks for the reviews !

/integrate

@openjdk
Copy link

openjdk bot commented Dec 1, 2025

Going to push as commit 5bd7db034aaf8aa6780945e02a7f9a35e16b036e.
Since your change was applied there have been 15 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 1, 2025
@openjdk openjdk bot closed this Dec 1, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 1, 2025
@openjdk
Copy link

openjdk bot commented Dec 1, 2025

@MBaesken Pushed as commit 5bd7db0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants