8372615: Many container tests fail when running rootless on cgroup v1 #28557
+58
−31
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi everyone,
Many container tests verify that various resource limits work as expected. However, when running containers in rootless mode on both Docker and Podman with cgroup v1, resource limits are not supported. This causes tests to fail with error messages like:
Resource limits are not supported and ignored on cgroups V1 rootless systems.To address this, we should skip these tests when running on configurations that don't support resource limits, similar to how we already handle other unsupported configurations (e.g., missing container engine or incompatibility with a specific cgroup version or container runtime).
To check for this, we now need to use
Metrics.systemMetrics().getProvider()fromjdk.internal.platform.Metricsto detect cgroup v1. I've added this functionality toDockerTestUtils, which is already used by all container tests. As a result, all container tests now need to include thejava.base/jdk.internal.platformmodule, even if they don't directly test resource limits.Testing:
hotspot/jtreg/containers/jdk/jdk/internal/platform/docker/on cgroup v1/v2 with Podman and Docker in both rootful and rootless configurations
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28557/head:pull/28557$ git checkout pull/28557Update a local copy of the PR:
$ git checkout pull/28557$ git pull https://git.openjdk.org/jdk.git pull/28557/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 28557View PR using the GUI difftool:
$ git pr show -t 28557Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28557.diff
Using Webrev
Link to Webrev Comment