type isin, remove redundant Iterable | Series
#1507
Merged
+54
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmp0xff
requested changes
Nov 26, 2025
cmp0xff
requested changes
Nov 26, 2025
Contributor
There was a problem hiding this comment.
Thank you @MarcoGorelli (for your patience)!
Edit: sorry I was about to approve, but found a place to work on when I took a second look.
cmp0xff
requested changes
Nov 30, 2025
Contributor
cmp0xff
left a comment
There was a problem hiding this comment.
Two more comments, after looking into the MultiIndex case more carefully.
cmp0xff
approved these changes
Dec 1, 2025
Contributor
cmp0xff
left a comment
There was a problem hiding this comment.
Thank you @MarcoGorelli ! And sorry for the back and forth. It just happened that I came up with new ideas how to challenge the existing typing and tests.
Member
Author
|
really appreciate your careful reviews, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seriesis alreadyIterable, soIterable | Serieswas redundant hereSeries.isindoesn't acceptdictin the same way thatDataFrame.isindoes:in the dataframe case, you can pass a per-column mapping
in the series one, it accidentally works but just because it's an iterable (i.e., only the keys are checked anyway)
Closes #xxxx (Replace xxxx with the Github issue number)
Tests added (Please use
assert_type()to assert the type of any return value)If I used AI to develop this pull request, I prompted it to follow
AGENTS.md.