Skip to content

Conversation

@realh4m
Copy link

@realh4m realh4m commented Nov 27, 2025

Description

Added exception tracking in process_video so callback errors raised in the worker loop are surfaced after reader/writer threads finish, preventing silent hangs when the callback crashes mid-stream.

Introduced read_finished to avoid draining the read queue unnecessarily once EOF is reached.

  • Issue: Fixes the silent failure where process_video could hang without any error when the callback raised an exception.
  • Dependencies: None.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How has this change been tested, please provide a testcase or example of how you tested the change?

Verified locally with a callback that raises an exception.

Any specific deployment considerations

No additional considerations; behavior change only affects process_video error handling.

Docs

  • Docs updated? What were the changes:

@realh4m realh4m requested a review from SkalskiP as a code owner November 27, 2025 11:03
@realh4m realh4m changed the title Fix process_video silent hang on callback error fix: process_video silent hang on callback error Nov 27, 2025
@CLAassistant
Copy link

CLAassistant commented Nov 27, 2025

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants