fix: process_video silent hang on callback error #2022
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added exception tracking in
process_videoso callback errors raised in the worker loop are surfaced after reader/writer threads finish, preventing silent hangs when the callback crashes mid-stream.Introduced
read_finishedto avoid draining the read queue unnecessarily once EOF is reached.process_videocould hang without any error when the callback raised an exception.Type of change
How has this change been tested, please provide a testcase or example of how you tested the change?
Verified locally with a callback that raises an exception.
Any specific deployment considerations
No additional considerations; behavior change only affects
process_videoerror handling.Docs