Add necessary CSS selectors for new FontAwesome #301
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New FontAwesome icons aren't guaranteed to have class `fa` anymore. Brands have `fab`, solid (normal) icons can have `fas`, regular icons (some are free, most are FontAwesome Pro only) have class `far` and light icons (FontAwesome Pro only) have `fal` as "primary" class. See rstudio/shiny#2260
Member
|
Thanks for this patch! If you haven't contributed a patch to an RStudio repository before, can I get you to sign an individual or corporate contributor agreement? You can send the signed copy to jj@rstudio.com. |
|
@AshesITR Any update on this PR? |
Contributor
Author
|
@jcheng5 The PR should be good to merge? |
Contributor
Author
|
bump? |
|
Checking again and found this is still not merged. I just made a temporary workaround in case there is other people needing this before the PR is merged. Below will force the icon to be v4.7 and there will not be a problem. icon_g <- icon("github")
icon_g[["attribs"]][["class"]] <- "fa fa-github"
|
Member
|
Gosh, sorry everyone who was waiting for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New FontAwesome icons aren't guaranteed to have class
faanymore. Brands havefab, solid (normal) icons can havefas, regular icons (some are free, most are FontAwesome Pro only) have classfarand light icons (FontAwesome Pro only) havefalas "primary" class.See rstudio/shiny#2260