Declare Optimizer as public
#351
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`README.md` already mandates to use `SCIP.Optimizer` when using SCIP.jl together with JuMP.jl. Additionally, this seems to be the only way how both work together. So `Optimizer` effectively has already been public API. Make this implicit assumption explicit, so that users and code checkers are not being mislead.
Collaborator
|
I'm going to close this. The When Julia releases a new Long-Term-Support (LTS) version, we will add For now, the public API is the API as documented in the README. |
Author
|
Ok, but wouldn't making the public line version-dependent check all the boxes? |
Collaborator
|
If you want to make changes I’ll review :) |
Author
|
Thanks. I hope this will do. At least it loaded the package both for 1.10 and 1.12 on my PC. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
README.mdalready mandates to useSCIP.Optimizerwhen using SCIP.jl together with JuMP.jl. Additionally, this seems to be the only way how both work together. SoOptimizereffectively has already been public API. Make this implicit assumption explicit, so that users and code checkers are not being mislead.