Simplify Property handling using map().getOrNull() #48349
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change improves the readability and idiomatic use of Gradle's `Property<T>` API by replacing an explicit `isPresent()` check with `map(...).getOrNull()`. The new version is functionally equivalent but more concise and aligns with recommended usage patterns in Gradle property handling. No behavioral changes. Signed-off-by: djlee <ddongjunn@gmail.com>
Member
|
Thanks for the suggestion, but I'm not sure that the update improves the code all that much and I'd rather leave things as they are. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change improves the readability and idiomatic use of Gradle's
Property<T>API by replacing an explicitisPresent()check withmap(...).getOrNull().The new version is functionally equivalent but more concise and aligns
with recommended usage patterns in Gradle property handling. Using
map().getOrNull()also avoids potential null-check boilerplate andreflects the intended design of Gradle's Property API.
No behavioral changes.
Signed-off-by: djlee ddongjunn@gmail.com