Skip to content

Reader: Add Freshly Pressed #24828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 4 commits into
base: trunk
Choose a base branch
from
Draft

Reader: Add Freshly Pressed #24828

wants to merge 4 commits into from

Conversation

@kean
Copy link
Contributor

@kean kean commented Sep 11, 2025 •
edited
Loading

Screenshot 2025-12-01 at 11 52 12 AM

@kean kean added this to the Someday milestone Sep 11, 2025
@kean kean added the Reader label Sep 11, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 11, 2025

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@kean kean marked this pull request as draft September 11, 2025 13:34
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Sep 11, 2025 •
edited
Loading

App Icon📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress
ConfigurationRelease-Alpha
Build Number30002
VersionPR #24828
Bundle IDorg.wordpress.alpha
Commit505077c
Installation URL0g9n9g9u5cpk8
 Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Sep 11, 2025 •
edited
Loading

App Icon📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack
ConfigurationRelease-Alpha
Build Number30002
VersionPR #24828
Bundle IDcom.jetpack.alpha
Commit505077c
Installation URL61o785921elb8
 Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@kean kean force-pushed the task/freshly-pressed branch from b524533 to 96c802d Compare November 25, 2025 13:11
@dangermattic
Copy link
Collaborator

dangermattic commented Nov 25, 2025

1 Message
📖 This PR is still a Draft: some checks will be skipped.

Generated by 🚫 Danger

@kean kean changed the title Add Freshly Pressed Reader: Add Freshly Pressed Nov 25, 2025
@kean kean modified the milestones: Someday, 26.6 Nov 25, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 28, 2025

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

kean
kean commented Dec 1, 2025
View reviewed changes
Modules/Sources/WordPressKitObjC/RemoteReaderPost.m
// A workaround for https://linear.app/a8c/issue/CMM-994/reader-invalid-featured-images-for-posts-in-freshly-pressed-feed
// The app does not support `mshots` images. We also never want to show
// screenshots of posts as featured images, so it's safe to skip these.
if ([imageURL containsString:@"wp.com/mshots/"]) {
Copy link
Contributor Author

@kean kean Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I figured we can opt-out of these on the app side as we never want mshots to be used from the app.

@kean kean requested a review from crazytonyli December 1, 2025 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@crazytonyli crazytonyli Awaiting requested review from crazytonyli

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Reader

Projects

None yet

Milestone

26.6

Development

Successfully merging this pull request may close these issues.

4 participants

@kean @wpmobilebot @dangermattic