chore: remove dev mode functionality on Proof Aggregation Service contract #2176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcosNicolau
approved these changes
Nov 26, 2025
JuArce
requested changes
Nov 26, 2025
| address public constant VERIFIER_MOCK_ADDRESS = address(0xFF); | ||
| /// if true, verification checks are skipped (only for test deployments) | ||
| /// This flag is set only at initialization and cannot be changed afterwards. | ||
| bool public devMode; |
Collaborator
There was a problem hiding this comment.
Suggested change
| bool public devMode; | |
| bool public immutable devMode; |
MauroToscano
requested changes
Nov 26, 2025
Contributor
MauroToscano
left a comment
There was a problem hiding this comment.
Make devMode immutable, and rename it to IS_DEV_MODE
Changes to gas cost
🧾 Summary (10% most significant diffs)
Full diff report 👇
|
Comment on lines
10
to
12
| function run(string memory alignedLayerDeploymentFilePath, string memory proofAggregatorConfigFilePath) external returns (address, address) { | ||
| string memory aligned_deployment_file = vm.readFile(alignedLayerDeploymentFilePath); | ||
| string memory config_data = vm.readFile(proofAggregatorConfigFilePath); |
Member
There was a problem hiding this comment.
This change can be removed right?
MarcosNicolau
approved these changes
Nov 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the mock functionality from the Aligned Proof Aggregation Service contract, since it had no real uses.
How to test
To test this PR, you should test that the normal workflows are working as expected. This means following these steps:
Type of change
Please delete options that are not relevant.
Checklist
testnet, everything else tostaging