Return error code to caller #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sameer Shaikh <sameer.shaikh@ibm.com>
Signed-off-by: Sameer Shaikh <sameer.shaikh@ibm.com>
Signed-off-by: Sameer Shaikh <sameer.shaikh@ibm.com>
Signed-off-by: Sameer Shaikh <sameer.shaikh@ibm.com>
Signed-off-by: Sameer Shaikh <sameer.shaikh@ibm.com>
Signed-off-by: Sameer Shaikh <sameer.shaikh@ibm.com>
Signed-off-by: Sameer Shaikh <sameer.shaikh@ibm.com>
Signed-off-by: Sameer Shaikh <sameer.shaikh@ibm.com>
Signed-off-by: Sameer Shaikh <sameer.shaikh@ibm.com>
Signed-off-by: Sameer Shaikh <sameer.shaikh@ibm.com>
Signed-off-by: Sameer Shaikh <sameer.shaikh@ibm.com>
Signed-off-by: Sameer Shaikh <sameer.shaikh@ibm.com>
arahamad
requested changes
Mar 11, 2025
Collaborator
arahamad
left a comment
There was a problem hiding this comment.
can you check this one as it will be applicable other places as well, we can discuss if required.
| resp, err := req.JSONBody(volumeTemplate).JSONSuccess(&share).JSONError(&apiErr).Invoke() | ||
| if err != nil { | ||
| if len(apiErr.Errors) > 0 { | ||
| apiErr.Errors[0].Status = resp.Status |
Collaborator
There was a problem hiding this comment.
what is the use of updating apiErr as you are not using it anywhere, if this is the case then why we can't do it in Invoke method only
Member
Author
There was a problem hiding this comment.
@arahamad We already discussed on this apiErr is the object mapped to error and filled by API error response. We can discuss again. Invoke method does populate the apierror object but in that we dont get status. So we have to populate it.
Signed-off-by: Sameer Shaikh <sameer.shaikh@ibm.com>
Signed-off-by: Sameer Shaikh <sameer.shaikh@ibm.com>
Signed-off-by: Sameer Shaikh <sameer.shaikh@ibm.com>
Signed-off-by: Sameer Shaikh <sameer.shaikh@ibm.com>
Signed-off-by: Sameer Shaikh <sameer.shaikh@ibm.com>
Signed-off-by: Sameer Shaikh <sameer.shaikh@ibm.com>
Signed-off-by: Sameer Shaikh <sameer.shaikh@ibm.com>
Signed-off-by: Sameer Shaikh <sameer.shaikh@ibm.com>
Signed-off-by: Sameer Shaikh <sameer.shaikh@ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.