Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: meta-pytorch/opacus
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: b8f3e32
Choose a base ref
...
head repository: meta-pytorch/opacus
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 7d4d3fe
Choose a head ref
  • 2 commits
  • 2 files changed
  • 2 contributors

Commits on May 12, 2025

  1. Corrected the type for the return of make_private function (#759) 

    Summary:
Pull Request resolved: #759

Previosuly, the return type of `make_private`  and `make_private_with_epsilon` was `Tuple[GradSampleModule, DPOptimizer, DataLoader]`, which was correct for hooks mode. When using ghost clipping, it additionally returns `criterion` which results in type checking errors in applications. Added the correct type in this fix.

Reviewed By: iden-kalemaj, aparna-aketi

Differential Revision: D74597461

fbshipit-source-id: e9cad4cbef6aa4dcf313e005086b871ebfd83b8d
    @EnayatUllah @facebook-github-bot
    EnayatUllah authored and facebook-github-bot committed May 12, 2025
    Configuration menu
    Copy the full SHA
    1490607 View commit details
    Browse the repository at this point in the history

Commits on May 13, 2025

  1. Provide warning about restriction on unclipped_num_std for adaptive c… 

    …lipping (#758)

Summary:

See discussion in Github issue: #757

1. Throw error when noise_mulitplier > 2 * unclipped_num_std

2. Provide logic for case when noise_multiplier = 0

Differential Revision: D74590917
    @iden-kalemaj @facebook-github-bot
    iden-kalemaj authored and facebook-github-bot committed May 13, 2025
    Configuration menu
    Copy the full SHA
    7d4d3fe View commit details
    Browse the repository at this point in the history
Loading